test(NODE-7366): add case 1 and 2 to retryable writes prose test 6#4887
Merged
test(NODE-7366): add case 1 and 2 to retryable writes prose test 6#4887
Conversation
nbbeeken
commented
Mar 10, 2026
| 'when a retry attempt fails with an error labeled NoWritesPerformed, drivers MUST return the original error', | ||
| { requires: { topology: 'replicaset', mongodb: '>=4.2.9' } }, | ||
| 'Case 1: Test that drivers return the correct error when receiving only errors without NoWritesPerformed', | ||
| { requires: { topology: 'replicaset', mongodb: '>=6.0' } }, |
Contributor
Author
There was a problem hiding this comment.
Maybe this requirement came later, it doesn't matter since these are just stub tests, but best not to be inconsistent
nbbeeken
added
the
Primary Review
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing cases to the Retryable Writes spec prose test #6 to validate error propagation behavior across multiple retry attempts under different combinations of NoWritesPerformed labeling.
Changes:
- Renames and expands prose test #6 into multiple explicit cases (Case 1–3).
- Adds new Case 1 and Case 2 coverage for “all errors without
NoWritesPerformed” and “all errors withNoWritesPerformed”. - Tightens/clarifies some inline prose and expectations (e.g., returned error code assertions).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dariakp
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Adding missing cases to prose test 6
Notes for Reviewers
What is the motivation for this change?
Full suite of retryable writes test 6
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript